feat: Added option to skip stripping elf #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
nikarh
added a commit
that referenced
this pull request
Apr 2, 2024
# Changelog ## [0.2.1] - 2024-04-02 ### Details #### Changed - Bump peter-evans/create-pull-request from 5 to 6 (#15) by @dependabot[bot] in #15 - Bump softprops/action-gh-release from 1 to 2 (#16) by @dependabot[bot] in #16 - Bump mathieudutour/github-tag-action from 6.1 to 6.2 (#17) by @dependabot[bot] in #17 - Added cargo-deny, enabled pedantic clippy, upgraded dependencies (#18) by @nikarh in #18 - Added option to skip stripping elf (#20) by @nikarh in #20 #### Fixed - Fixed publish pipeline permissions by @nikarh - Better error message when vita-parse-core is not found (#19) by @nikarh in #19 Co-authored-by: nikarh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though in most cases stripping should be enabled since a hello world binary with std with debug symbols yields a ~13mb elf for Vita, debugging isolated problems could benefit from dwarf symbols.
This PR adds a flag readable from
Cargo.tomlwhich can toggle stripping on and off (with on by default)